New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin: built-in func row_count #4853

Merged
merged 11 commits into from Oct 28, 2017

Conversation

Projects
None yet
5 participants
@mccxj
Contributor

mccxj commented Oct 20, 2017

for #3961

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Oct 20, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Oct 20, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 20, 2017

Member

@mccxj Thanks!

Member

shenli commented Oct 20, 2017

@mccxj Thanks!

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 26, 2017

Member

@mccxj any update ?

Member

zz-jason commented Oct 26, 2017

@mccxj any update ?

@zz-jason zz-jason added this to the 1.1 milestone Oct 26, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Oct 26, 2017

@winkyao PTAL

zz-jason and others added some commits Oct 27, 2017

@winkyao

LGTM

@zz-jason zz-jason merged commit 25879d3 into pingcap:master Oct 28, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.423%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@mccxj mccxj deleted the mccxj:patch-issue-3961 branch Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment