New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix a bug occured in select sum(float col)*0.1 #4854

Merged
merged 3 commits into from Oct 21, 2017

Conversation

Projects
None yet
4 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 20, 2017

The problem is commented in the code.

PTAL @shenli @zz-jason @coocood

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 20, 2017

Member

/run-all-tests

Member

shenli commented Oct 20, 2017

/run-all-tests

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 20, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Oct 20, 2017

/run-all-test

@XuHuaiyu XuHuaiyu changed the title from expression: fix a bug occured in select sum(1.2e2)*0.1 to expression: fix a bug occured in select sum(float col)*0.1 Oct 20, 2017

@ngaut

ngaut approved these changes Oct 21, 2017

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 21, 2017

Member

LGTM

Member

ngaut commented Oct 21, 2017

LGTM

@ngaut ngaut merged commit 4867bcf into pingcap:master Oct 21, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the XuHuaiyu:tpch branch Oct 21, 2017

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Oct 21, 2017

expression: fix a bug occured in select sum(float col)*0.1 (#4854)
* expression: fix a bug occured in select sum(1.2e2)*0.1

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 21, 2017

expression: fix a bug occured in select sum(float col)*0.1 (#4854)
* expression: fix a bug occured in select sum(1.2e2)*0.1

ngaut added a commit that referenced this pull request Oct 21, 2017

expression: fix a bug occured in select sum(float col)*0.1 (#4854) (#…
…4855)

* expression: fix a bug occured in select sum(1.2e2)*0.1

shenli added a commit to shenli/tidb that referenced this pull request Oct 24, 2017

expression: fix a bug occured in select sum(float col)*0.1 (#4854)
* expression: fix a bug occured in select sum(1.2e2)*0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment