New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add Row interface #4859

Merged
merged 5 commits into from Oct 23, 2017

Conversation

Projects
None yet
5 participants
@coocood
Member

coocood commented Oct 22, 2017

Add Row interface and make []types.Datum implements it.
So we can change the implementation to Chunk Row in the future.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 22, 2017

Show outdated Hide outdated expression/column.go Outdated
Show outdated Hide outdated util/types/row.go Outdated
@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 23, 2017

Member

/run-all-test

Member

zz-jason commented Oct 23, 2017

/run-all-test

Show outdated Hide outdated util/types/row.go Outdated
Show outdated Hide outdated util/types/row.go Outdated
Show outdated Hide outdated util/types/row.go Outdated
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Oct 23, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 23, 2017

Member

LGTM

Member

zz-jason commented Oct 23, 2017

LGTM

@lamxTyler

LGTM

lamxTyler and others added some commits Oct 23, 2017

@winoros winoros merged commit ed7f68c into pingcap:master Oct 23, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:row-interface branch Oct 23, 2017

shenli added a commit to shenli/tidb that referenced this pull request Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment