New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fix rename table bug #4862

Merged
merged 20 commits into from Oct 26, 2017

Conversation

6 participants
@zimulala
Member

zimulala commented Oct 23, 2017

Fix #4858

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Oct 23, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 23, 2017

tk.MustExec("create database rename2")
tk.MustExec("create table rename1.t (a int primary key auto_increment)")
tk.MustExec("rename table rename1.t to rename2.t1")
tk.MustExec("insert rename2.t1 values ()")

This comment has been minimized.

@winkyao

winkyao Oct 23, 2017

Member

add test case: insert rename1.t values()

@winkyao

winkyao Oct 23, 2017

Member

add test case: insert rename1.t values()

This comment has been minimized.

@zimulala

zimulala Oct 23, 2017

Member

rename2.t1 ? Done.

@zimulala

zimulala Oct 23, 2017

Member

rename2.t1 ? Done.

This comment has been minimized.

@winkyao

winkyao Oct 23, 2017

Member

no, I means insert back to rename1.t, it should fail as expected.

@winkyao

winkyao Oct 23, 2017

Member

no, I means insert back to rename1.t, it should fail as expected.

This comment has been minimized.

@zimulala

zimulala Oct 24, 2017

Member

I did it in line 253.

@zimulala

zimulala Oct 24, 2017

Member

I did it in line 253.

This comment has been minimized.

@winkyao

winkyao Oct 24, 2017

Member

Okay

@winkyao
@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Oct 23, 2017

PTAL @shenli

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Oct 23, 2017

Member

/run-all-tests

Member

zimulala commented Oct 23, 2017

/run-all-tests

Show outdated Hide outdated ddl/table.go

zimulala added some commits Oct 24, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Oct 25, 2017

Member

/run-all-test

Member

winkyao commented Oct 25, 2017

/run-all-test

winkyao and others added some commits Oct 25, 2017

Show outdated Hide outdated ddl/table.go

zimulala added some commits Oct 25, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Oct 25, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 25, 2017

Member

LGTM

Member

coocood commented Oct 25, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 25, 2017

Member

/run-all-test

Member

coocood commented Oct 25, 2017

/run-all-test

@zz-jason zz-jason added this to the 1.1 milestone Oct 26, 2017

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Oct 26, 2017

@hanfei1991 hanfei1991 merged commit 4550e91 into pingcap:master Oct 26, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:fix-rename-bug branch Oct 26, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment