New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: parse and ignore REPLICATION CLIENT/SLAVE, USAGE privileges in grant statement #4870

Merged
merged 3 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 23, 2017

Fix #4865

Parse Replication Client, Replication Slave, Usage privileges, but ignore them.
This change introduced PrivilegeType(0), it need to be skipped somewhere.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 24, 2017

Member

LGTM

Member

shenli commented Oct 24, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 24, 2017

@ngaut

ngaut approved these changes Oct 25, 2017

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 25, 2017

Member

/run-all-tests

Member

ngaut commented Oct 25, 2017

/run-all-tests

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Oct 25, 2017

Member

LGTM

Member

ngaut commented Oct 25, 2017

LGTM

@tiancaiamao tiancaiamao merged commit b0d20c9 into pingcap:master Oct 25, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.403%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:usage-repl-priv branch Oct 25, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment