New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add straight_join_syntax support, just treat it as JOIN. #4872

Merged
merged 3 commits into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@winkyao
Member

winkyao commented Oct 23, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao

winkyao Oct 23, 2017

Member

STRAIGHT_JOIN is similar to JOIN, except that the left table is always read before the right table. This can be used for those (few) cases for which the join optimizer processes the tables in a suboptimal order.

https://dev.mysql.com/doc/refman/5.7/en/join.html

Member

winkyao commented Oct 23, 2017

STRAIGHT_JOIN is similar to JOIN, except that the left table is always read before the right table. This can be used for those (few) cases for which the join optimizer processes the tables in a suboptimal order.

https://dev.mysql.com/doc/refman/5.7/en/join.html

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 23, 2017

Member

LGTM

Member

shenli commented Oct 23, 2017

LGTM

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Oct 23, 2017

Member

rest LGTM

Member

jackysp commented Oct 23, 2017

rest LGTM

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Oct 23, 2017

@jackysp PTAL

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Oct 24, 2017

Member

/run-all-tests

Member

jackysp commented Oct 24, 2017

/run-all-tests

@winkyao winkyao merged commit 2f3d5e8 into pingcap:master Oct 24, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.507%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:support_straight_join_syntax branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment