New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add tracing config and grpc interceptor middleware #4877

Merged
merged 10 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 23, 2017

I don't know why package github.com/grpc-ecosystem/go-grpc-middleware/tags is filtered by gitignore.
I have to add it back so vendor is touched.

This commit just change two places actually:

  1. setupTracing in main.go to initialize opentracing package
  2. add opentracing.ClientInterceptor to grpc.Dial option

@tiancaiamao tiancaiamao changed the title from [WIP] *: add tracing middleware to grpc interceptor to *: add tracing config and grpc interceptor middleware Oct 24, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao
Contributor

tiancaiamao commented Oct 24, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Oct 24, 2017

Contributor

/run-all-tests

Contributor

tiancaiamao commented Oct 24, 2017

/run-all-tests

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 24, 2017

Member

LGTM

Member

zz-jason commented Oct 24, 2017

LGTM

@zz-jason zz-jason added this to the 1.1 milestone Oct 24, 2017

@tiancaiamao tiancaiamao merged commit 460e1b8 into pingcap:master Oct 25, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:grpc-tracing branch Oct 25, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment