New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: join's default value length should be changed when do column pruning. #4882

Merged
merged 4 commits into from Oct 25, 2017

Conversation

Projects
4 participants
@winoros
Member

winoros commented Oct 24, 2017

After column pruning, the LogicalJoin.DefaultValues may not be expected, and cause bug when do merge join

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros
Member

winoros commented Oct 24, 2017

@zz-jason zz-jason added this to the 1.1 milestone Oct 25, 2017

@hanfei1991 hanfei1991 added this to Others in Planner Oct 25, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Oct 25, 2017

Member

LGTM

Member

hanfei1991 commented Oct 25, 2017

LGTM

@zz-jason

LGTM

@winoros winoros changed the title from plan: join's default value should changed in column pruning size. to plan: join's default value length should be changed when do column pruning. Oct 25, 2017

@hanfei1991 hanfei1991 merged commit 3d71672 into pingcap:master Oct 25, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Oct 30, 2017

@XuHuaiyu XuHuaiyu referenced this pull request Oct 30, 2017

Merged

cherry pick #4882 #4828 #4941

coocood added a commit that referenced this pull request Oct 30, 2017

cherry pick #4882 #4828 (#4941)
*  plan: join's default value length should be changed when do column pruning. (#4882)

* plan: fix distinct bug. (#4828)

@winoros winoros deleted the winoros:join-default-values branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment