New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-server: fix binlog client is not initialized correctly #4887

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 25, 2017

var clientConn *grpc.ClientConn
tidb.DialPumpClientWithRetry(cfg.BinlogSocket, clientConn, util.DefaultMaxRetries, dialerOpt)

This can't change clientConn, anyhow.
And TiDB will panic when we try to write binlog, as clientConn is nil.

@XuHuaiyu @shenli

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 25, 2017

Member

LGTM

Member

shenli commented Oct 25, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 25, 2017

@coocood PTAL

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 25, 2017

Member

LGTM

Member

coocood commented Oct 25, 2017

LGTM

@coocood coocood merged commit b0d9e8d into pingcap:master Oct 25, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

@tiancaiamao tiancaiamao deleted the tiancaiamao:binlog-client branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment