New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: ALTER TABLE t ENGINE = 'string' #4904

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
5 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 26, 2017

MySQL support this:

mysql> alter table t engine = 'innodb';
ERROR 1105 (HY000): line 1 column 29 near "" (total length 29)

but TiDB just parse:

mysql> alter table t engine = innodb;

It should be ENGINE = String rather than ENGINE = Identifier

@wolfstudy

@breeswish

This comment has been minimized.

Show comment
Hide comment
@breeswish

breeswish Oct 26, 2017

Member

LGTM

Member

breeswish commented Oct 26, 2017

LGTM

@jackysp

LGTM

@jackysp

This comment has been minimized.

Show comment
Hide comment
@jackysp

jackysp Oct 26, 2017

Member

/run-all-test

Member

jackysp commented Oct 26, 2017

/run-all-test

@zz-jason zz-jason added this to the 1.1 milestone Oct 26, 2017

@winoros winoros merged commit c55ec3d into pingcap:master Oct 26, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.419%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 27, 2017

@tiancaiamao tiancaiamao deleted the tiancaiamao:alter-table-engine branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment