New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix a bug of index reader. #4910

Merged
merged 4 commits into from Oct 27, 2017

Conversation

Projects
None yet
4 participants
@winoros
Member

winoros commented Oct 26, 2017

Schema of IndexReader's copTask is not same as the above root task.
This will make index of column wrong.

I'll try to add a simple test in later commit.
test is added in integration test.

PTAL @hanfei1991 @lamxTyler @XuHuaiyu

winoros and others added some commits Oct 26, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991
Member

hanfei1991 commented Oct 26, 2017

fix #4878

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Oct 26, 2017

Member

/run-integration-common-test tidb-test=yiding/issue4878

Member

winoros commented Oct 26, 2017

/run-integration-common-test tidb-test=yiding/issue4878

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Oct 26, 2017

Member

LGTM

Member

zz-jason commented Oct 26, 2017

LGTM

@lamxTyler

LGTM

@hanfei1991 hanfei1991 merged commit 6605c6b into pingcap:master Oct 27, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

hanfei1991 added a commit to hanfei1991/tidb that referenced this pull request Oct 27, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 27, 2017

@hanfei1991 hanfei1991 referenced this pull request Oct 30, 2017

Merged

cherry pick a fix #4920

@winoros winoros deleted the winoros:bugfix branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment