New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: reduce "growslice" in "dumpRowValuesBinary" #4916

Merged
merged 9 commits into from Nov 2, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Oct 26, 2017

fix #4915

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 27, 2017

@coocood PTAL

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 27, 2017

Member

I think we should change all the dump functions to append input []bytes and return it, like the functions in util/codec.

Member

coocood commented Oct 27, 2017

I think we should change all the dump functions to append input []bytes and return it, like the functions in util/codec.

zz-jason added some commits Oct 31, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 1, 2017

Member

LGTM

Member

zimulala commented Nov 1, 2017

LGTM

@zimulala zimulala added the status/LGT1 label Nov 1, 2017

Show outdated Hide outdated server/conn.go
Show outdated Hide outdated server/util.go
Show outdated Hide outdated server/util.go
Show outdated Hide outdated server/util.go

zz-jason added some commits Nov 2, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 2, 2017

Member

/run-all-test

Member

zz-jason commented Nov 2, 2017

/run-all-test

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 2, 2017

Member

LGTM

Member

coocood commented Nov 2, 2017

LGTM

@coocood

coocood approved these changes Nov 2, 2017

@zz-jason zz-jason merged commit 91196a2 into pingcap:master Nov 2, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.169%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:dev/dumpRowValuesBinary branch Nov 2, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment