New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: extract process of getting full cmp type to method. #4935

Merged
merged 3 commits into from Oct 31, 2017

Conversation

Projects
None yet
4 participants
@winoros
Member

winoros commented Oct 28, 2017

Since in function also need this to make result better, extract the this part to single method.
PTAL @XuHuaiyu @zz-jason

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Oct 28, 2017

Member

Good Job !
LGTM

Member

hanfei1991 commented Oct 28, 2017

Good Job !
LGTM

Show outdated Hide outdated expression/builtin_compare.go Outdated
Show outdated Hide outdated expression/builtin_compare.go Outdated
Show outdated Hide outdated expression/builtin_compare.go Outdated
Show outdated Hide outdated expression/builtin_compare.go Outdated
Show outdated Hide outdated expression/builtin_compare.go Outdated
Show outdated Hide outdated expression/builtin_compare.go Outdated
@XuHuaiyu

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 31, 2017

Contributor

/run-all-test

Contributor

XuHuaiyu commented Oct 31, 2017

/run-all-test

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Oct 31, 2017

@hanfei1991 hanfei1991 merged commit cf70670 into pingcap:master Oct 31, 2017

11 of 12 checks passed

jenkins-ci-tidb/integration-ddl-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.011%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winoros winoros deleted the winoros:extract branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment