New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,store/tikv: opentracing for TableReader, IndexReader, IndexLookup executor #4937

Merged
merged 12 commits into from Nov 7, 2017

Conversation

Projects
None yet
5 participants
@tiancaiamao
Contributor

tiancaiamao commented Oct 28, 2017

This branch is modified based on #4929
This diff with master is not viewable.

@winkyao winkyao added the status/WIP label Oct 30, 2017

@zz-jason zz-jason added this to the 1.1 milestone Oct 31, 2017

@tiancaiamao tiancaiamao removed the status/WIP label Nov 1, 2017

@tiancaiamao tiancaiamao changed the title from [WIP] executor,store/tikv: opentracing for TableReader, IndexReader, IndexLookup executor to executor,store/tikv: opentracing for TableReader, IndexReader, IndexLookup executor Nov 1, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao
Contributor

tiancaiamao commented Nov 1, 2017

Show outdated Hide outdated executor/new_distsql.go Outdated
Show outdated Hide outdated executor/new_distsql.go Outdated
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 1, 2017

Member

LGTM

Member

coocood commented Nov 1, 2017

LGTM

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao
Contributor

tiancaiamao commented Nov 2, 2017

Show outdated Hide outdated executor/new_distsql.go Outdated

tiancaiamao added some commits Nov 2, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

LGTM

Member

shenli commented Nov 7, 2017

LGTM

@shenli

shenli approved these changes Nov 7, 2017

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Nov 7, 2017

Contributor

/run-all-tests

Contributor

tiancaiamao commented Nov 7, 2017

/run-all-tests

@tiancaiamao tiancaiamao merged commit bbf0b92 into pingcap:master Nov 7, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls First build on master at 73.617%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:opentracing-executor branch Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment