New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql: use utf8_bin for unsupported column collation. #4939

Merged
merged 3 commits into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@coocood
Member

coocood commented Oct 29, 2017

Coprocessor will return error if non-supported collation is push down.

distsql: use utf8_bin for unsupported column collation when convert t…
…o protobuffer.

Coprocessor will return error if non-supported collation is push down.
if ok {
return int32(v)
v := mysql.CollationNames[c]
if v == mysql.BinaryCollationID {

This comment has been minimized.

@winkyao

winkyao Oct 30, 2017

Member

add some comment here?

@winkyao

winkyao Oct 30, 2017

Member

add some comment here?

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 30, 2017

Member

LGTM

Member

shenli commented Oct 30, 2017

LGTM

@winkyao

LGTM

@winkyao winkyao merged commit 5c6fa44 into pingcap:master Oct 30, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:pb-collate branch Oct 30, 2017

coocood added a commit to coocood/tidb that referenced this pull request Oct 30, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment