New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec: fix a bug in json decode. #4949

Merged
merged 2 commits into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@hicqu
Contributor

hicqu commented Oct 30, 2017

Previously after decode a JSON from row, we didn't
advance the index in the bytes. This PR fix this.

codec: fix a bug in json decode.
Previously after decode a JSON from row, we didn't
advance the index in the bytes. This PR fix this.

@hicqu hicqu requested review from coocood, GregoryIan and shenli Oct 30, 2017

@GregoryIan

This comment has been minimized.

Show comment
Hide comment
@GregoryIan

GregoryIan Oct 30, 2017

Contributor

LGTM

Contributor

GregoryIan commented Oct 30, 2017

LGTM

@coocood

LGTM

@coocood coocood merged commit 67bddaa into pingcap:master Oct 30, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.306%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@hicqu hicqu deleted the hicqu:hicqu/json-codec-fix branch Oct 30, 2017

coocood added a commit that referenced this pull request Oct 30, 2017

codec: fix a bug in json decode. (#4949) (#4952)
Previously after decode a JSON from row, we didn't
advance the index in the bytes. This PR fix this.

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 31, 2017

codec: fix a bug in json decode. (#4949)
Previously after decode a JSON from row, we didn't
advance the index in the bytes. This PR fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment