New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix #4954, insert column char(4) with latin1 charset by incorrect padding #4962

Merged
merged 16 commits into from Nov 1, 2017

Conversation

Projects
None yet
5 participants
@winkyao
Member

winkyao commented Oct 31, 2017

to #4954

winkyao added some commits Oct 31, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Oct 31, 2017

Show outdated Hide outdated plan/stats.go
Show outdated Hide outdated plan/new_physical_plan_builder.go
Show outdated Hide outdated expression/builtin_compare.go

winkyao added some commits Nov 1, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 1, 2017

Member

LGTM

Member

zimulala commented Nov 1, 2017

LGTM

@zimulala zimulala added the status/LGT1 label Nov 1, 2017

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 1, 2017

Contributor

/run-all-test
LGTM

Contributor

XuHuaiyu commented Nov 1, 2017

/run-all-test
LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 and removed status/LGT1 labels Nov 1, 2017

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Nov 1, 2017

Member

/run-all-test

Member

iamxy commented Nov 1, 2017

/run-all-test

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Nov 1, 2017

Member

/run-sqllogic-test

Member

iamxy commented Nov 1, 2017

/run-sqllogic-test

winkyao added some commits Nov 1, 2017

@winkyao

This comment has been minimized.

Show comment
Hide comment
@winkyao
Member

winkyao commented Nov 1, 2017

@coocood PTAL

winkyao and others added some commits Nov 1, 2017

@coocood

coocood approved these changes Nov 1, 2017

@coocood coocood merged commit 1b9cc41 into pingcap:master Nov 1, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 71.713%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@winkyao winkyao deleted the winkyao:fix_issue4954 branch Nov 1, 2017

winkyao added a commit to winkyao/tidb that referenced this pull request Nov 1, 2017

jackysp added a commit that referenced this pull request Nov 2, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment