New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix alter table add column(...) #4963

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
5 participants
@foxmailed
Contributor

foxmailed commented Oct 31, 2017

No description provided.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Oct 31, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Oct 31, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 31, 2017

Member

Fix #3575
@foxmailed Thanks!

Member

shenli commented Oct 31, 2017

Fix #3575
@foxmailed Thanks!

@shenli shenli added the contribution label Oct 31, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli
Member

shenli commented Oct 31, 2017

LGTM
@zimulala @coocood PTAL

@ngaut

ngaut approved these changes Oct 31, 2017

Well done. LGTM.

@ngaut ngaut merged commit ba9b1f7 into pingcap:master Oct 31, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

winkyao added a commit to winkyao/tidb that referenced this pull request Oct 31, 2017

@foxmailed foxmailed deleted the foxmailed:fix_alter_table_add_col branch Oct 31, 2017

winkyao added a commit that referenced this pull request Nov 1, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment