New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: enable push float down to tikv. #4967

Merged
merged 4 commits into from Nov 2, 2017

Conversation

Projects
None yet
6 participants
@winoros
Copy link
Member

winoros commented Oct 31, 2017

Float constant should be pushed down to tikv.
Actually, all cast sig should be also pushed down to tikv. But there's something to do with error handling.
PTAL @XuHuaiyu @zz-jason @hanfei1991

winoros added some commits Oct 31, 2017

@shenli

This comment has been minimized.

Copy link
Member

shenli commented Oct 31, 2017

Is TiKV able to handle float?

@shenli

This comment has been minimized.

Copy link
Member

shenli commented Oct 31, 2017

/run-all-tests

@shenli

This comment has been minimized.

Copy link
Member

shenli commented Oct 31, 2017

/cc @BusyJay

@winoros

This comment has been minimized.

Copy link
Member

winoros commented Nov 1, 2017

/run-all-tests

@BusyJay

This comment has been minimized.

Copy link
Member

BusyJay commented Nov 1, 2017

Yes, for +, -, *, / operations and abs, ceil, floor functions.

@winoros

This comment has been minimized.

Copy link
Member

winoros commented Nov 1, 2017

/run-unit-test

@winoros

This comment has been minimized.

Copy link
Member

winoros commented Nov 1, 2017

The failed case of jenkins' unit test is fixed in #4969 .It failed because test code is not stable enough.

@iamxy

This comment has been minimized.

Copy link
Member

iamxy commented Nov 1, 2017

/run-all-tests

@zz-jason
Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason added this to the 1.1 milestone Nov 2, 2017

@XuHuaiyu
Copy link
Contributor

XuHuaiyu left a comment

LGTM

@XuHuaiyu XuHuaiyu merged commit cb08085 into pingcap:master Nov 2, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 6, 2017

@winoros winoros deleted the winoros:push-down branch Nov 13, 2017

winoros added a commit to winoros/tidb that referenced this pull request Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment