New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan, executor: improve hash join to support all join types #4987

Merged
merged 30 commits into from Nov 9, 2017

Conversation

Projects
None yet
5 participants
@zz-jason
Member

zz-jason commented Nov 2, 2017

  1. improve HashJoinExec to support Semi Join, Anti Semi Join, Left Outer Semi Join and Anti Left Outer Semi Join
  2. improve joinResultGenerators
  3. HashSemiJoin is retained to support ApplyJoinExec
  4. add order by to some tests to make unit test stable
  5. split ApplyJoinExec, HashSemiJoinExec, NestedLoopJoinExec to separate files

zz-jason added some commits Nov 1, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 2, 2017

Member

/run-unit-test

Member

zz-jason commented Nov 2, 2017

/run-unit-test

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 2, 2017

Member

/run-all-test tidb-test=pr/392

Member

zz-jason commented Nov 2, 2017

/run-all-test tidb-test=pr/392

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason
Member

zz-jason commented Nov 2, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 2, 2017

Member

It's hard to review if you split/rename files and change the code in the same PR.
Can you just modify the code in this PR and split/rename files in the next PR?

Member

coocood commented Nov 2, 2017

It's hard to review if you split/rename files and change the code in the same PR.
Can you just modify the code in this PR and split/rename files in the next PR?

zz-jason added some commits Nov 3, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 3, 2017

Member

@coocood updated, PTAL

Member

zz-jason commented Nov 3, 2017

@coocood updated, PTAL

zz-jason and others added some commits Nov 3, 2017

zz-jason added some commits Nov 7, 2017

Merge branch 'master' of https://github.com/pingcap/tidb into dev/sem…
…ijoin/hashjoin and resolve conflicts

zz-jason added some commits Nov 7, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 7, 2017

Member

/run-all-tests tidb-test=pr/392

Member

zz-jason commented Nov 7, 2017

/run-all-tests tidb-test=pr/392

zz-jason added some commits Nov 8, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 8, 2017

Member

LGTM

Member

hanfei1991 commented Nov 8, 2017

LGTM

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 8, 2017

Member

/run-all-tests tidb-test=pr/392

Member

zz-jason commented Nov 8, 2017

/run-all-tests tidb-test=pr/392

@coocood

coocood approved these changes Nov 8, 2017

LGTM

zz-jason and others added some commits Nov 8, 2017

@coocood coocood added status/LGT2 and removed status/LGT1 labels Nov 8, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 8, 2017

Member

/run-all-tests

Member

zz-jason commented Nov 8, 2017

/run-all-tests

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Nov 8, 2017

Contributor

/run-integration-common-tests tidb-test=pr/398

Contributor

XuHuaiyu commented Nov 8, 2017

/run-integration-common-tests tidb-test=pr/398

@zz-jason zz-jason added this to the 1.1 milestone Nov 9, 2017

@zz-jason zz-jason merged commit 68cd5b0 into pingcap:master Nov 9, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:dev/semijoin/hashjoin branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment