New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: move safepoint checker to tikvStore. #4998

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Nov 3, 2017

The safePointChecker should always run no matter we start gc worker or not. So it's better to be started with tikvStore.

@disksing disksing requested review from coocood, tiancaiamao and atmzhou Nov 3, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 3, 2017

Member

LGTM

Member

coocood commented Nov 3, 2017

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Nov 3, 2017

Member

/run-all-tests

Member

disksing commented Nov 3, 2017

/run-all-tests

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Nov 3, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Nov 3, 2017

LGTM

@disksing disksing merged commit 2b9a096 into pingcap:master Nov 3, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 73.569%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:gc branch Nov 3, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment