New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, ast: Support part of window function ast #5002

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
6 participants
@wangyisong1996
Contributor

wangyisong1996 commented Nov 4, 2017

Added window clause, over clause (with only non-modified window) support of ast.
Also added ROW_NUMBER() and RANK() window functions support of ast.
These statements and functions will be parsed but not planned.
e.g.

mysql> select rank() over() from t;
ERROR 1105 (HY000): UnknownType: *ast.WindowSpec
@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 4, 2017

Member

LGTM

Member

hanfei1991 commented Nov 4, 2017

LGTM

type WindowFuncExpr struct {
funcNode
// F is the function name.
F string

This comment has been minimized.

@zz-jason

zz-jason Nov 5, 2017

Member

s/F/Name/

@zz-jason

zz-jason Nov 5, 2017

Member

s/F/Name/

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

LGTM

Member

shenli commented Nov 7, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

/run-all-tests

Member

shenli commented Nov 7, 2017

/run-all-tests

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Nov 7, 2017

Member

/run-all-tests

Member

iamxy commented Nov 7, 2017

/run-all-tests

@wangyisong1996

This comment has been minimized.

Show comment
Hide comment
@wangyisong1996

wangyisong1996 Nov 8, 2017

Contributor

/run-all-test -tidb-test=1.0.0

Contributor

wangyisong1996 commented Nov 8, 2017

/run-all-test -tidb-test=1.0.0

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Nov 8, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 8, 2017

Member

@wangyisong1996
Please fix CI.

Member

zimulala commented Nov 8, 2017

@wangyisong1996
Please fix CI.

@hanfei1991 hanfei1991 merged commit 27b3e21 into pingcap:dev/window-function Nov 8, 2017

8 of 12 checks passed

jenkins-ci-tidb/common-test Jenkins job failed
Details
jenkins-ci-tidb/integration-common-test Jenkins job failed
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job failed
Details
jenkins-ci-tidb/mybatis-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on dev/window-function at 72.565%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

wangyisong1996 added a commit to wangyisong1996/tidb that referenced this pull request Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment