New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support sql_mode `high_not_precedence` #5011

Merged
merged 9 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@spongedu
Contributor

spongedu commented Nov 5, 2017

for #4768 , support sql_mode high_not_precedence

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Nov 5, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Nov 5, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@@ -790,7 +792,7 @@ import (
%left '*' '/' '%' div mod
%left '^'
%left '~' neg
%right not
%right not not2

This comment has been minimized.

@zz-jason

zz-jason Nov 7, 2017

Member

can we change not2 to another more specified name ?

@zz-jason

zz-jason Nov 7, 2017

Member

can we change not2 to another more specified name ?

This comment has been minimized.

@spongedu

spongedu Nov 7, 2017

Contributor

@zz-jason MySQL defines token like this. I think it's better to keep consistent with MySQL.

@spongedu

spongedu Nov 7, 2017

Contributor

@zz-jason MySQL defines token like this. I think it's better to keep consistent with MySQL.

This comment has been minimized.

@zz-jason

zz-jason Nov 7, 2017

Member

ok

@zz-jason

@zz-jason zz-jason added this to the 1.1 milestone Nov 7, 2017

spongedu added some commits Nov 7, 2017

@zz-jason zz-jason added the status/LGT1 label Nov 7, 2017

Show outdated Hide outdated parser/parser.y
Show outdated Hide outdated parser/parser.y
Show outdated Hide outdated parser/parser.y
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

LGTM

Member

coocood commented Nov 7, 2017

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Nov 8, 2017

@zz-jason

LGTM

@zz-jason zz-jason merged commit 6b6d424 into pingcap:master Nov 8, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:high_not_precedence branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment