New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: remove joinBuilder #5019

Merged
merged 3 commits into from Nov 6, 2017

Conversation

Projects
None yet
6 participants
@zz-jason
Member

zz-jason commented Nov 6, 2017

No description provided.

@winoros winoros added the status/LGT1 label Nov 6, 2017

@ngaut

This comment has been minimized.

Show comment
Hide comment
@ngaut

ngaut Nov 6, 2017

Member

/run-all-tests

Member

ngaut commented Nov 6, 2017

/run-all-tests

zz-jason and others added some commits Nov 6, 2017

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Nov 6, 2017

Member

/run-all-tests

Member

lamxTyler commented Nov 6, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 6, 2017

Member

LGTM

Member

coocood commented Nov 6, 2017

LGTM

@coocood

coocood approved these changes Nov 6, 2017

@hanfei1991 hanfei1991 merged commit 7a71b14 into pingcap:master Nov 6, 2017

11 of 12 checks passed

jenkins-ci-tidb/integration-compatibility-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 73.586%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:dev/delete/joinbuilder branch Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment