New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove read-only statement from transaction auto retry #5026

Merged
merged 10 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@wentaoxu
Contributor

wentaoxu commented Nov 6, 2017

  1. remove explain statement from retry
  2. remove all select statement from retry except It has setvar functions
  3. remove execute statement from retry if it is read-only statement
    @shenli @coocood
Show outdated Hide outdated executor/compiler.go
Show outdated Hide outdated executor/read_only_checker.go
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

For prepared statement, Compile is not called, they use CompileExecutePreparedStmt.

Member

coocood commented Nov 7, 2017

For prepared statement, Compile is not called, they use CompileExecutePreparedStmt.

@wentaoxu

This comment has been minimized.

Show comment
Hide comment
@wentaoxu

wentaoxu Nov 7, 2017

Contributor

@coocood yes, I lost this function.

Contributor

wentaoxu commented Nov 7, 2017

@coocood yes, I lost this function.

@wentaoxu

This comment has been minimized.

Show comment
Hide comment
@wentaoxu
Contributor

wentaoxu commented Nov 8, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 8, 2017

Member

LGTM

Member

coocood commented Nov 8, 2017

LGTM

@zz-jason

LGTM

@wentaoxu

This comment has been minimized.

Show comment
Hide comment
@wentaoxu

wentaoxu Nov 8, 2017

Contributor

/run-all-tests

Contributor

wentaoxu commented Nov 8, 2017

/run-all-tests

@wentaoxu wentaoxu merged commit 49f2a90 into pingcap:master Nov 8, 2017

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

wentaoxu added a commit to wentaoxu/tidb that referenced this pull request Nov 9, 2017

remove read-only statement from transaction auto retry (#5026)
* *: Ignore readonly statement when retrying

* remove explain statement from retry
* remove all select statement from retry except It has setvar functions
* remove execute statement from retry if it is read-only statement

wentaoxu added a commit to wentaoxu/tidb that referenced this pull request Nov 14, 2017

remove read-only statement from transaction auto retry (#5026)
* *: Ignore readonly statement when retrying

* remove explain statement from retry
* remove all select statement from retry except It has setvar functions
* remove execute statement from retry if it is read-only statement

shenli added a commit that referenced this pull request Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment