New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: support sql_mode `NO_UNSIGNED_SUB` #5030

Merged
merged 10 commits into from Nov 9, 2017

Conversation

Projects
None yet
6 participants
@spongedu
Contributor

spongedu commented Nov 6, 2017

support sql_mode NO_UNSIGNED_SUB for TiDB

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Nov 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason zz-jason added this to the 1.1 milestone Nov 7, 2017

Show outdated Hide outdated mysql/const_test.go
Show outdated Hide outdated mysql/const.go

spongedu added some commits Nov 7, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

LGTM

Member

coocood commented Nov 7, 2017

LGTM

@winoros winoros added the status/LGT1 label Nov 7, 2017

@zz-jason

This comment has been minimized.

Show comment
Hide comment
@zz-jason

zz-jason Nov 8, 2017

Member

@spongedu plz resolve conflicts

Member

zz-jason commented Nov 8, 2017

@spongedu plz resolve conflicts

spongedu added some commits Nov 9, 2017

@zz-jason

LGTM

@zz-jason zz-jason merged commit 9680972 into pingcap:master Nov 9, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@spongedu spongedu deleted the spongedu:mode_no_unsigned_sub branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment