New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Save reorg doneHandle regularly #5041

Merged
merged 8 commits into from Nov 9, 2017

Conversation

Projects
None yet
5 participants
@zimulala
Member

zimulala commented Nov 7, 2017

If we update handle failed, that makes us need to redo the previous operation of adding index.
Encounter an error like "update handle err [tikv:9001]PD server timeout[try again later]" in #4986.
Fix #4986

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 7, 2017

Member

/run-all-tests

Member

zimulala commented Nov 7, 2017

/run-all-tests

@zimulala zimulala changed the title from ddl: Make handle more accrate in some cases to ddl: Make handle more accurate in some cases Nov 7, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala

zimulala Nov 7, 2017

Member

/run-integration-ddl-test

Member

zimulala commented Nov 7, 2017

/run-integration-ddl-test

Show outdated Hide outdated ddl/reorg.go
Show outdated Hide outdated ddl/reorg.go
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 7, 2017

Member

I think the title of this PR should be save reorg doneHandle regularly.
The old code only safe doneHandle when an error occurred, but the cause of that error may also cause update done handle to fail.

Member

coocood commented Nov 7, 2017

I think the title of this PR should be save reorg doneHandle regularly.
The old code only safe doneHandle when an error occurred, but the cause of that error may also cause update done handle to fail.

@zimulala zimulala changed the title from ddl: Make handle more accurate in some cases to ddl: Save reorg doneHandle regularly Nov 8, 2017

@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Nov 8, 2017

Show outdated Hide outdated ddl/reorg.go
Show outdated Hide outdated ddl/reorg.go
@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Nov 8, 2017

PTAL @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 8, 2017

Member

LGTM

Member

coocood commented Nov 8, 2017

LGTM

@winoros winoros added the status/LGT1 label Nov 8, 2017

Show outdated Hide outdated ddl/reorg.go
Show outdated Hide outdated ddl/reorg_test.go
@zimulala

This comment has been minimized.

Show comment
Hide comment
@zimulala
Member

zimulala commented Nov 9, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 9, 2017

Member

LGTM

Member

shenli commented Nov 9, 2017

LGTM

@shenli

shenli approved these changes Nov 9, 2017

@shenli shenli added status/LGT2 and removed status/LGT1 labels Nov 9, 2017

@zimulala zimulala merged commit 5b9640f into pingcap:master Nov 9, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:update-handle branch Nov 9, 2017

zimulala added a commit to zimulala/tidb that referenced this pull request Nov 9, 2017

zimulala added a commit that referenced this pull request Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment