New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: build and use count-min sketch #5042

Merged
merged 9 commits into from Nov 8, 2017

Conversation

Projects
None yet
5 participants
@lamxTyler
Member

lamxTyler commented Nov 7, 2017

This PR builds count-min sketch when analyze and use it for point queries. Especially, we do not build it for primary key when it is handle and the unique index.
PTAL @coocood @hanfei1991 @winoros @zz-jason

Show outdated Hide outdated statistics/cmsketch.go Outdated
@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Nov 7, 2017

Member

Should we merge this PR after TiKV support count-min sketch?

Member

shenli commented Nov 7, 2017

Should we merge this PR after TiKV support count-min sketch?

@lamxTyler

This comment has been minimized.

Show comment
Hide comment
@lamxTyler

lamxTyler Nov 8, 2017

Member

@shenli We can, but do not have to, because the code does not assume that tikv will build count-min sketch despite we send the request.

Member

lamxTyler commented Nov 8, 2017

@shenli We can, but do not have to, because the code does not assume that tikv will build count-min sketch despite we send the request.

lamxTyler added some commits Nov 8, 2017

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 8, 2017

Member

LGTM

Member

coocood commented Nov 8, 2017

LGTM

@zz-jason

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Nov 8, 2017

@zz-jason zz-jason added this to the 1.1 milestone Nov 8, 2017

@zz-jason zz-jason merged commit 30a080d into pingcap:master Nov 8, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the lamxTyler:cms branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment