New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: set undetermined error if not recover from an rpc error. #5043

Merged
merged 5 commits into from Nov 8, 2017

Conversation

@disksing
Member

disksing commented Nov 8, 2017

If encounter rpc error, record it in sender, then mark the error undetermined later.

Show outdated Hide outdated store/tikv/2pc.go
Show outdated Hide outdated store/tikv/2pc.go

disksing added some commits Nov 8, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Nov 8, 2017

Member

/run-all-tests

Member

disksing commented Nov 8, 2017

/run-all-tests

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Nov 8, 2017

Member

LGTM

Member

coocood commented Nov 8, 2017

LGTM

@tiancaiamao

This comment has been minimized.

Show comment
Hide comment
@tiancaiamao

tiancaiamao Nov 8, 2017

Contributor

LGTM

Contributor

tiancaiamao commented Nov 8, 2017

LGTM

@disksing disksing merged commit 2d79d59 into pingcap:master Nov 8, 2017

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:undetermined branch Nov 8, 2017

disksing added a commit to disksing/tidb that referenced this pull request Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment