New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: return error instead of panic when subquery in join ON condition #5062

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
3 participants
@coocood
Member

coocood commented Nov 10, 2017

No description provided.

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood
Member

coocood commented Nov 10, 2017

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Nov 10, 2017

Member

LGTM

Member

hanfei1991 commented Nov 10, 2017

LGTM

@winoros

LGTM

@hanfei1991 hanfei1991 merged commit 7cdcc1d into pingcap:master Nov 10, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:subquer-in-join branch Nov 10, 2017

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment