Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privileges: grant privilege identified by password should be hash string #5129

Merged
merged 8 commits into from Nov 20, 2017
Merged

privileges: grant privilege identified by password should be hash string #5129

merged 8 commits into from Nov 20, 2017

Conversation

buggithubs
Copy link
Contributor

@buggithubs buggithubs commented Nov 16, 2017

fix #4196

PTAL @tiancaiamao

test case

The test is consistent with version 5.7 of MySQL

grant select on *.* to 'genius1'@'%' identified by password '123123'; 	
ERROR 1827 (HY000): The password hash doesn't have the expected format. Check if the correct password algorithm is being used with the PASSWORD() function.
grant select on *.* to 'genius2'@'%' identified by password '*E56A114692FE0DE073F9A1DD68A00EEB9703F3F';
ERROR 1827 (HY000): The password hash doesn't have the expected format. Check if the correct password algorithm is being used with the PASSWORD() function
grant select on *.* to 'genius3'@'%' identified by password '*E56A114692FE0DE073F9A1DD68A00EEB9703F3F1'; 
Query OK, 0 rows affected, 2 warnings (0.01 sec)
grant select on *.* to 'genius4'@'%' identified by password '0E56A114692FE0DE073F9A1DD68A00EEB9703F3F9'; 
ERROR 1827 (HY000): The password hash doesn't have the expected format. Check if the correct password algorithm is being used with the PASSWORD() function.
grant select on *.* to 'genius5'@'%' identified by password '*E56A114692FE0DE073F9A1DD68A00EEB9703F3XX'; 
Query OK, 0 rows affected, 2 warnings (0.01 sec)

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2017

CLA assistant check
All committers have signed the CLA.

@winoros winoros changed the title Zhengqian/add password hash privileges: grant privilege identified by password should be hash string Nov 16, 2017
@zz-jason
Copy link
Member

@buggithubs you can run make check to format the code

@shenli
Copy link
Member

shenli commented Nov 17, 2017

@buggithubs Please fix CI.

@buggithubs
Copy link
Contributor Author

@zz-jason Thanks for reminding
@shenli Complete repair

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2017
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2017
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason
Copy link
Member

/run-integration-common-test
/run-integration-compatibility-test
/run-integration-ddl-test

@coocood coocood merged commit 6287514 into pingcap:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grant privilege identified by password should be hash string
7 participants