New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privileges: grant privilege identified by password should be hash string #5129
Merged
coocood
merged 8 commits into
pingcap:master
from
buggithubs:zhengqian/add_password_hash
Nov 20, 2017
Merged
privileges: grant privilege identified by password should be hash string #5129
coocood
merged 8 commits into
pingcap:master
from
buggithubs:zhengqian/add_password_hash
Nov 20, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
changed the title
Zhengqian/add password hash
privileges: grant privilege identified by password should be hash string
Nov 16, 2017
@buggithubs you can run |
@buggithubs Please fix CI. |
LGTM |
zz-jason
approved these changes
Nov 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winoros
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Nov 17, 2017
/run-all-tests |
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4196
PTAL @tiancaiamao
test case
The test is consistent with version 5.7 of MySQL