Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: always rebuild plan for retry. #5219

Merged
merged 1 commit into from Nov 25, 2017

Conversation

@coocood
Copy link
Member

commented Nov 25, 2017

Fixs record and index inconsistency bug.

tidb: always rebuild plan for retry.
Fixs record and index inconsistency bug.
@shenli

This comment has been minimized.

Copy link
Member

commented Nov 25, 2017

/run-all-tests tidb-test=release-1.0

@@ -168,6 +168,7 @@ type ExecuteStmt struct {

Name string
UsingVars []ExprNode
ExecID uint32

This comment has been minimized.

Copy link
@shenli

shenli Nov 25, 2017

Member

When will this ExecID be used?

This comment has been minimized.

Copy link
@coocood

coocood Nov 25, 2017

Author Member

To build Execute plan.

ctx context.Context
StmtNode ast.StmtNode

Ctx context.Context

This comment has been minimized.

Copy link
@zimulala

zimulala Nov 25, 2017

Member

Why export it?

This comment has been minimized.

Copy link
@coocood

coocood Nov 25, 2017

Author Member

It will be constructed by another package.

@shenli

This comment has been minimized.

Copy link
Member

commented Nov 25, 2017

LGTM

1 similar comment
@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2017

LGTM

@shenli shenli merged commit b8bcf9c into pingcap:release-1.0 Nov 25, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on release-1.0 at 72.539%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:fix-retry branch Nov 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.