executor_test: improve show full processlist tests #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
@darren Thanks! |
|
/ok-to-test |
|
/run-all-tests |
shenli
reviewed
Nov 27, 2017
util/testkit/testkit.go
Outdated
| @@ -48,6 +48,21 @@ func (res *Result) Check(expected [][]interface{}) { | |||
| res.c.Assert(got, check.Equals, need, res.comment) | |||
| } | |||
|
|
|||
| // CheckAt asserts the result of selected columns equals the expected results. | |||
| func (res *Result) CheckAt(cols []int, expected [][]interface{}) { | |||
| var rows [][]string | |||
There was a problem hiding this comment.
rows := make([][]string, 0, len(expected))
util/testkit/testkit.go
Outdated
| func (res *Result) CheckAt(cols []int, expected [][]interface{}) { | ||
| var rows [][]string | ||
| for i := range res.rows { | ||
| var row []string |
There was a problem hiding this comment.
row := make([]string, 0, len(cols))
winoros
changed the title
|
LGTM |
winoros
added
contribution
XuHuaiyu
reviewed
Nov 27, 2017
util/testkit/testkit.go
Outdated
| func (res *Result) CheckAt(cols []int, expected [][]interface{}) { | ||
| for _, e := range expected { | ||
| if len(cols) != len(e) { | ||
| panic("lens of cols and expected cols should be equal") |
There was a problem hiding this comment.
why use panic here but not res.c.Assert ?
|
LGTM |
tiancaiamao
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test cases added in PR #4739 hardcoded query id, it brings some trouble that each time new test cases added like in #5158 and #5210 we have to modify the hardcoded query id.
This PR fixes this.
@shenli @mccxj