Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: notify TiDB update privilege after alter/drop user #5226

Merged
merged 2 commits into from Nov 27, 2017

Conversation

@tiancaiamao
Copy link
Contributor

commented Nov 27, 2017

Alter User and Drop User forget to do it.

Fix #5216

@breeswish

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

LGTM

@@ -219,6 +219,7 @@ func (e *SimpleExec) executeAlterUser(s *ast.AlterUserStmt) error {
errMsg := "Operation ALTER USER failed for " + strings.Join(failedUsers, ",")
return terror.ClassExecutor.New(CodeCannotUser, errMsg)
}
domain.GetDomain(e.ctx).NotifyUpdatePrivilege(e.ctx)

This comment has been minimized.

Copy link
@shenli

shenli Nov 27, 2017

Member

If we meet error here, add a log.

This comment has been minimized.

Copy link
@tiancaiamao

tiancaiamao Nov 27, 2017

Author Contributor

NotifyUpdatePrivilege already log errors.

@shenli

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

LGTM

@shenli

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

/run-all-tests

@shenli
shenli approved these changes Nov 27, 2017

@tiancaiamao tiancaiamao merged commit e440ac3 into pingcap:master Nov 27, 2017

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:notify-update-privilege branch Nov 27, 2017

tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Nov 27, 2017
coocood added a commit that referenced this pull request Nov 29, 2017
executor: notify TiDB update privilege after alter/drop user (#5226) (#…
…5232)

* executor: notify TiDB update privilege after alter/drop user (#5226)

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.