executor, infoschema: return a pseudo profiling table when system var profiling is set to 1 #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… profiling is set to 1
Conflicts: executor/executor_test.go
coocood
reviewed
Mar 6, 2018
infoschema/tables.go
Outdated
| @@ -1033,6 +1060,9 @@ func (it *infoschemaTable) getRows(ctx sessionctx.Context, cols []*table.Column) | |||
| fullRows = dataForTableConstraints(dbs) | |||
| case tableFiles: | |||
| case tableProfiling: | |||
| if v, ok := ctx.GetSessionVars().GetSystemVar("profiling"); ok && v == "1" { | |||
|
PTAL @coocood |
zimulala
reviewed
Mar 6, 2018
sessionctx/variable/varsutil.go
Outdated
| @@ -123,8 +123,8 @@ func SetSessionSystemVar(vars *SessionVars, name string, value types.Datum) erro | |||
| return vars.SetSystemVar(name, sVal) | |||
| } | |||
|
|
|||
| // tidbOptOn could be used for all tidb session variable options, we use "ON"/1 to turn on those options. | |||
| func tidbOptOn(opt string) bool { | |||
| // TIDBOptOn could be used for all tidb session variable options, we use "ON"/1 to turn on those options. | |||
|
LGTM |
|
/run-all-tests |
This was referenced Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5666
Navicat autorun sql
to get the QUERY_ID.
This commit returns a pseudo profiling table when profiling is set to 1.
PTAL @coocood