Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support table partition in show create table stmt #6292

Merged

Conversation

@zhexuany
Copy link
Member

zhexuany commented Apr 16, 2018

support table partition in show create table statement.

zhexuany added 3 commits Apr 16, 2018
@zhexuany zhexuany requested review from shenli, jackysp and coocood Apr 16, 2018
@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Apr 16, 2018

Regarding of range partition, some syntaxes are not yet supported. Further change will be made later.

@zhexuany

This comment has been minimized.

Copy link
Member Author

zhexuany commented Apr 16, 2018

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Apr 16, 2018

LGTM

1 similar comment
@tiancaiamao

This comment has been minimized.

Copy link
Contributor

tiancaiamao commented Apr 16, 2018

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

tiancaiamao commented Apr 16, 2018

/run-all-tests

@jackysp

This comment has been minimized.

Copy link
Member

jackysp commented Apr 16, 2018

I think the create partition syntax with max value is wrong. @zhexuany @coocood

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Apr 16, 2018

@jackysp
It can be executed in MySQL.

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Apr 16, 2018

/run-unit-test

@zhexuany zhexuany merged commit 0d7a71c into pingcap:master Apr 16, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zhexuany zhexuany deleted the zhexuany:support_table_partition_in_show_create_table branch Apr 16, 2018
zhexuany added a commit to zhexuany/tidb that referenced this pull request Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.