Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, session: replace new line and add user in query log (#6748) #6920

Merged
merged 1 commit into from Jun 27, 2018

Conversation

@lysu
Copy link
Member

lysu commented Jun 27, 2018

What have you changed? (mandatory)

cherry pick #6748

refer #6898

What are the type of the changes (mandatory)?

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested (mandatory)?

  • unit test
  • integration test

This change is Reviewable

So we can grep a keyword to get the query, without the need to look up the query in the full log.
user name is also needed for auditing purpose.
@lysu lysu requested a review from coocood Jun 27, 2018
@lysu

This comment has been minimized.

Copy link
Member Author

lysu commented Jun 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

jackysp left a comment

LGTM

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Jun 27, 2018

LGTM

@coocood coocood merged commit 6207c48 into pingcap:release-2.0 Jun 27, 2018
11 checks passed
11 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lysu lysu deleted the lysu:dev-cherry-pick-slow-log branch Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.