Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, types: fix bug of insert into unsigned float/double (#6939) #6940

Merged
merged 1 commit into from Jul 2, 2018

Conversation

@XuHuaiyu
Copy link
Contributor

commented Jun 29, 2018

cherry-pick #6939

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

WARNING: DATA RACE
Read at 0x00c42013cfb8 by goroutine 45:
github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop.func1()
/home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:562 +0x1f6

@shenli

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

@tiancaiamao Is the data race issue fixed in master?

@shenli shenli added the type/bug-fix label Jun 29, 2018

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2018

I'm not sure, the CI log is gone. @shenli @coocood

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

/run-unit-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

LGTM

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

PTAL @zz-jason

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason merged commit b74990f into pingcap:release-2.0 Jul 2, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.