Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support session variable 'warning_count' and 'error_count' #6945

Merged
merged 6 commits into from Jul 2, 2018

Conversation

@spongedu
Copy link
Contributor

commented Jun 29, 2018

What have you changed? (mandatory)

  1. Support show @@waring_count and show @@error_count in TiDB

  2. The modification that add an return value of error type for ResetStmtCtx is to make kisielk/errcheck happy.

What are the type of the changes (mandatory)?

enhancement

How has this PR been tested (mandatory)?

Unittest

spongedu added 4 commits Jun 29, 2018
@shenli

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

/run-all-tests

Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Jul 2, 2018
@jackysp
jackysp approved these changes Jul 2, 2018
Copy link
Member

left a comment

LGTM

@coocood

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

@spongedu
Can we remove WarningCount?

@spongedu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

@coocood we still need WarningCount. The behavior of the new added NumWarnings is a little different from WarningCount in behavior. For example, if the last sql statement generates a warning;
both WarningCount and NumWarnings 1, then if we execute SHOW WARNINGS after that, WarningCount would be 0, and NumWarnings is still 1.

@coocood

This comment has been minimized.

Copy link
Member

commented Jul 2, 2018

LGTM

@coocood coocood merged commit 2292844 into pingcap:master Jul 2, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.