Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregation: handle non-integer input for bit related aggregate functions #6994

Merged
merged 4 commits into from Jul 5, 2018

Conversation

@crazycs520
Copy link
Member

crazycs520 commented Jul 5, 2018

What have you changed? (mandatory)

fix issue#6987
bit_or doesn't handle decimal

What are the type of the changes (mandatory)?

Bug fix

How has this PR been tested (mandatory)?

Does this PR affect documentation (docs/docs-cn) update? (optional)

No.

Copy link
Contributor

XuHuaiyu left a comment

add a test case for this.

@zz-jason zz-jason added this to In progress in support intra-operator parallelism via automation Jul 5, 2018
@zz-jason zz-jason added this to the 2.1 milestone Jul 5, 2018
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jul 5, 2018

@crazycs520 You can add some tests in executor/aggregate_test.go

@crazycs520

This comment has been minimized.

Copy link
Member Author

crazycs520 commented Jul 5, 2018

@zz-jason @XuHuaiyu Already add a test. PTAL.
bit_and, bit_xor also have the same problem too, I'll fix it.

Copy link
Member

zz-jason left a comment

LGTM

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor

XuHuaiyu commented Jul 5, 2018

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Member Author

crazycs520 commented Jul 5, 2018

@XuHuaiyu @zz-jason I fix the same bug of bit_and, bit_xor in this pr, PTAL.

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor

XuHuaiyu commented Jul 5, 2018

/run-all-tests

Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason changed the title aggregation: fix bit_or handle decimal bugs aggregation: handle non-integer input for bit related aggregate functions Jul 5, 2018
@crazycs520

This comment has been minimized.

Copy link
Member Author

crazycs520 commented Jul 5, 2018

/run-all-tests

@winoros
winoros approved these changes Jul 5, 2018
Copy link
Member

winoros left a comment

LGTM

@zz-jason zz-jason merged commit 73dc86c into pingcap:master Jul 5, 2018
11 checks passed
11 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
support intra-operator parallelism automation moved this from In progress to Done Jul 5, 2018
@crazycs520 crazycs520 deleted the crazycs520:dev/fix-bit-or branch Jul 5, 2018
zhexuany added a commit to zhexuany/tidb that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.