Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix panic caused by outdated feedback (#7128) #7155

Merged
merged 2 commits into from Jul 25, 2018

Conversation

@lamxTyler
Copy link
Member

commented Jul 25, 2018

What have you changed? (mandatory)

Cherry pick #7128

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Unit test.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0

@zimulala
Copy link
Member

left a comment

LGTM

@shenli

This comment has been minimized.

Copy link
Member

commented Jul 25, 2018

LGTM

@shenli
shenli approved these changes Jul 25, 2018

@shenli shenli added status/LGT2 and removed status/LGT1 labels Jul 25, 2018

@shenli shenli merged commit a78037d into pingcap:release-2.0 Jul 25, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the lamxTyler:feedback-panic branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.