Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,sessionctx: Add correctness for more system variables #7196

Merged
merged 28 commits into from Aug 19, 2018

Conversation

@spongedu
Copy link
Contributor

commented Jul 30, 2018

What have you changed? (mandatory)

What is the type of the changes? (mandatory)

for #7195

  • Improvement
  • Compatibility

How has this PR been tested? (mandatory)

Unittest

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Does this PR affect tidb-ansible update? (mandatory)

Does this PR need to be added to the release notes? (mandatory)

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

spongedu added 5 commits Aug 1, 2018
@spongedu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@zz-jason PTAL

Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

@spongedu seems we should specially handle the string "default".

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 10, 2018

/run-common-test

@spongedu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2018

@zz-jason We've dealed with value default in ValidateSetSystemVar, but the default may translate into the specific default value in function getVarValue in executor/set.go. The former test fail is due to unreasonable usage of ParseInt on an uint64 default value(18446744073709551615) .

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 10, 2018

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 10, 2018

@jackysp PTAL

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

@zhexuany

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

/run-all-tests

executor/set_test.go Outdated Show resolved Hide resolved
Copy link
Member

left a comment

lgtm

@zhexuany zhexuany dismissed winoros’s stale review Aug 16, 2018

comments need to be addressed.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

/run-all-tests

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Aug 17, 2018
@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

/run-integration-ddl-test

@zz-jason zz-jason merged commit d5ab70c into pingcap:master Aug 19, 2018
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Feb 21, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Feb 22, 2019
zz-jason added a commit that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.