Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: Change the default value of charset/collation to utfbmb4/utf8mb4_bin #7198

Merged
merged 5 commits into from Aug 10, 2018

Conversation

@shenli
Copy link
Member

commented Jul 31, 2018

What have you changed? (mandatory)

Change the default value of charset/collation to utfbmb4/utf8mb4_bin.
TiDB does not support Latin charset now. So change them to utf8mb4 to avoid potential issues.

Fix #7046

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Exists tests.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Yes

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

Yes

release note:
Change the default value of charset/collation related variable to utfbmb4/utf8mb4_bin.

Refer to a related PR or issue link (optional)

#7046

Benchmark result if necessary (optional)

No

Add a few positive/negative examples (optional)

No

Copy link
Member

left a comment

LGTM

Copy link
Member

left a comment

LGTM

@jackysp

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

/run-all-tests

@coocood

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

Why not utf8 and utf8_bin?
There are many places where we use uft8 as default charset.

Copy link
Member

left a comment

Why not utf8 and utf8_bin?

@shenli

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2018

There is no difference between utf8 and utf8mb4 in golang.
utf8mb4 is the recommended charset. See: https://medium.com/@adamhooper/in-mysql-never-use-utf8-use-utf8mb4-11761243e434
@coocood

@shenli

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2018

/run-unit-test

@shenli shenli added the status/DNM label Aug 1, 2018
shenli added 2 commits Jul 31, 2018
…f8mb4_bin

TiDB does not support latin charset now. So change them to utf8mb4 to
avoid potential issues.
Change the default charset/collation from utf8mb4 to utf8.
@shenli shenli dismissed stale reviews from jackysp and zz-jason via 9bec0ac Aug 8, 2018
@shenli shenli force-pushed the shenli:server-charset branch from 097ebe4 to 9bec0ac Aug 8, 2018
@shenli

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2018

@coocood PTAL

@coocood
coocood approved these changes Aug 9, 2018
@coocood

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

LGTM

@coocood coocood removed the status/DNM label Aug 9, 2018
@shenli

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2018

/run-unit-test

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

/run-all-tests

@zz-jason zz-jason merged commit 3e8815f into pingcap:master Aug 10, 2018
11 checks passed
11 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.