Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, ddl: get the correct result of "show create table" when running "add index" (#6993) #7243

Merged
merged 3 commits into from Aug 2, 2018

Conversation

@zimulala
Copy link
Member

commented Aug 2, 2018

cherry pick #6993

What have you changed? (mandatory)

Get the correct result of "show create table" when executing "add index".
Fix #6991

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

No.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No.

Does this PR affect tidb-ansible update? (mandatory)

No.

Does this PR need to be added to the release notes? (mandatory)

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@zimulala

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zimulala

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@shenli
shenli approved these changes Aug 2, 2018
Copy link
Member

left a comment

LGTM

@coocood
coocood approved these changes Aug 2, 2018
Copy link
Member

left a comment

LGTM

@coocood coocood merged commit 50fdc54 into pingcap:release-2.0 Aug 2, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zimulala zimulala deleted the zimulala:show-create branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.