Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle max_allowed_packet warnings for pad functions (#7171) #7244

Merged
merged 3 commits into from Aug 2, 2018

Conversation

@zz-jason
Copy link
Member

commented Aug 2, 2018

What have you changed? (mandatory)

cherry pick #7171 to release 2.0

What is the type of the changes? (mandatory)

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Does this PR affect tidb-ansible update? (mandatory)

Does this PR need to be added to the release notes? (mandatory)

release note:

handle max_allowed_packet warnings for pad functions

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zimulala
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

1 similar comment
@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood
coocood approved these changes Aug 2, 2018
Copy link
Member

left a comment

LGTM

@coocood coocood added the status/LGT2 label Aug 2, 2018

@shenli

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

/rebuild

@shenli

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

@zimulala PTAL again

@zz-jason zz-jason merged commit 13d711f into pingcap:release-2.0 Aug 2, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:cherrypick/7171 branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.