Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: skip inner rows when the join keys contains NULL #7255

Merged
merged 5 commits into from Aug 5, 2018

Conversation

@zz-jason
Copy link
Member

commented Aug 2, 2018

What have you changed? (mandatory)

This PR skips the inner rows which contains NULL value in the join key for "Merge Join" and "Index Join", thus they behaves the same as "Hash Join".

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

existing tests.

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Does this PR affect tidb-ansible update? (mandatory)

Does this PR need to be added to the release notes? (mandatory)

Yes

release note:
Fix the wrong behavior of `Merge Join` and `Index Join` in a special scenario.

Refer to a related PR or issue link (optional)

to #7226

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

/run-all-tests

@winoros
Copy link
Member

left a comment

A more better way is add a selection which has is not null filter below the join.
But it's okay for now.
lgtm

@winoros
winoros approved these changes Aug 3, 2018
@lysu

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

/run-unit-test

@birdstorm
Copy link
Member

left a comment

LGTM

@birdstorm birdstorm added status/LGT2 and removed status/LGT1 labels Aug 5, 2018

@zz-jason zz-jason merged commit 7e48ab1 into pingcap:master Aug 5, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@zz-jason zz-jason deleted the zz-jason:dev/fix-merge-index-join branch Aug 5, 2018

zz-jason added a commit to zz-jason/tidb that referenced this pull request Aug 7, 2018
zz-jason added a commit that referenced this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.