Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: collect execution details and output them in slow query log #7364

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@coocood
Copy link
Member

commented Aug 13, 2018

Cherry-pick #7302

What problem does this PR solve?

Makes it easier to find the culprit slow query that makes the cluster slow.

What is changed and how it works?

Records every coprocessor execution details and merge them into StmtContext.
Output the merged details in slow-query log.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Related changes

  • Need to update the documentation
  • Need to be included in the release note
@coocood

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2018

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2018

LGTM

@zhexuany
Copy link
Member

left a comment

LGTM

@coocood

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0

@coocood coocood added the status/LGT2 label Aug 13, 2018

@coocood coocood merged commit 23b6f05 into pingcap:release-2.0 Aug 13, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:collect-details-2.0 branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.