Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin: add json quote #7832

Merged
merged 4 commits into from Feb 12, 2019

Conversation

@overbool
Copy link
Contributor

commented Oct 6, 2018

This is my first PR to tidb, so please be gentle ;-)

What problem does this PR solve?

a part of #7546

What is changed and how it works?

add a built in function json_quote

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has interface methods change

Related changes

  • Need to be included in the release note

This change is Reviewable

@sre-bot

This comment has been minimized.

Copy link

commented Oct 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Copy link

commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

@shenli

This comment has been minimized.

Copy link
Member

commented Oct 6, 2018

@overbool Thanks!

@shenli

This comment has been minimized.

Copy link
Member

commented Oct 6, 2018

/ok-to-test

@shenli

This comment has been minimized.

Copy link
Member

commented Oct 6, 2018

/run-all-tests

@crazycs520
Copy link
Contributor

left a comment

LGTM

@mccxj mccxj referenced this pull request Oct 8, 2018

Open

Support remaining JSON functions from MySQL 5.7 #7546

22 of 28 tasks complete
@zz-jason

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

@overbool any update?

@overbool

This comment has been minimized.

Copy link
Contributor Author

commented Nov 26, 2018

@overbool any update?

Sorry for my delay, I will update it in a few day.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

@overbool friendly ping 😄 Any update?

@overbool overbool force-pushed the overbool:feat/add-json-quote branch from 8feb23d to f4d164d Jan 2, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Feb 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #7832 into master will increase coverage by <.01%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7832      +/-   ##
==========================================
+ Coverage   67.24%   67.25%   +<.01%     
==========================================
  Files         371      371              
  Lines       77203    77223      +20     
==========================================
+ Hits        51916    51937      +21     
- Misses      20645    20647       +2     
+ Partials     4642     4639       -3
Impacted Files Coverage Δ
expression/distsql_builtin.go 27.94% <0%> (-0.11%) ⬇️
types/json/binary_functions.go 84.33% <0%> (-0.33%) ⬇️
expression/builtin_json.go 76.11% <64.7%> (-0.04%) ⬇️
store/tikv/gcworker/gc_worker.go 41.14% <0%> (-0.43%) ⬇️
util/filesort/filesort.go 76.48% <0%> (+0.31%) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad4684...14fd406. Read the comment docs.

@zz-jason zz-jason merged commit 0b363f1 into pingcap:master Feb 12, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@morgo morgo referenced this pull request Feb 13, 2019

Merged

sql: add json quote #894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.