Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix bug empty string in "ESCAPED BY" subclause of "FIELDS" cause panic #7880

Merged
merged 3 commits into from Oct 14, 2018

Conversation

Projects
None yet
4 participants
@lzmhhh123
Copy link
Member

lzmhhh123 commented Oct 12, 2018

What problem does this PR solve?

When fields clause has empty string of escaped by subclause. It will cause panic.

What is changed and how it works?

Simple change. Just add a judgement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
ci
@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 12, 2018

@lzmhhh123 please add some tests.

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 12, 2018

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Oct 12, 2018

/run-all-tests

@jackysp
Copy link
Member

jackysp left a comment

LGTM

@jackysp jackysp added status/LGT2 and removed status/LGT1 labels Oct 12, 2018

@ngaut ngaut merged commit 4de8887 into pingcap:master Oct 14, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Oct 23, 2018

lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Oct 23, 2018

@lzmhhh123 lzmhhh123 deleted the lzmhhh123:dev/TiDB1760 branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.