Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix invailid ddl job panic (#7940) #7958

Merged
merged 2 commits into from Oct 20, 2018

Conversation

Projects
None yet
5 participants
@crazycs520
Copy link
Contributor

commented Oct 19, 2018

What problem does this PR solve?

cherry-pick from #7940

What is changed and how it works?

Check List

Tests

  • Unit testCode changes
@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

LGTM

@zimulala
Copy link
Member

left a comment

LGTM

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Oct 19, 2018

@zz-jason

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

/run-all-tests

@ngaut ngaut added status/LGT3 and removed status/LGT2 labels Oct 19, 2018

@ngaut

ngaut approved these changes Oct 19, 2018

Copy link
Member

left a comment

LGTM

@ngaut

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

/run-all-tests

2 similar comments
@crazycs520

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2018

/run-all-tests

@iamxy

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

/run-all-tests

@ngaut ngaut merged commit 60364fe into pingcap:release-2.1 Oct 20, 2018

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.